-
-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new worklow to track the voting process #1278
Conversation
Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process |
Status: for testing |
Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process |
@derberg as suggested in the requirements here is the sample https://github.com/AayushSaini101/Vote/blob/main/voteTrackingDetails.md, The workflow first create two files that is voteTracking.json and voteTrackingDetails.md. The json file is used to parse the requests frequently |
Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some initial comments
.github/workflows/vote-tracker.yml
Outdated
- name: Run vote tracker script | ||
id: vote_tracker | ||
if: | | ||
github.event.comment.user.login == 'git-vote[bot]' && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we have this login validation on a job level, to basically not run entire job if this was not met? case with comment body
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done @derberg
@derberg I have added one more value for the isVotedInLast3Months column that is Sample: https://github.com/AayushSaini101/Vote/blob/main/TSC_VOTING_OVERVIEW.md |
@asyncapi/bounty_team |
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@derberg Done: Added md file as well in the starting added comment in md as well as in the md file generator |
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
TSC_VOTING_OVERVIEW.md
Outdated
| [Amzani](https://github.com/Amzani) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | 2024-06-13 | true | 2024-06-14 | 2 | 0 | 0 | 1 | | ||
| [smoya](https://github.com/smoya) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | 2024-05-28 | true | 2024-06-14 | 2 | 0 | 0 | 1 | | ||
| [souvikns](https://github.com/souvikns) | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | Member has not participated in all previous voting process. | Member has not participated in all previous voting process. | 2024-06-14 | 0 | 0 | 0 | 3 | | ||
| [alequetzalli](https://github.com/alequetzalli) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | 2024-06-04 | true | 2024-06-14 | 3 | 0 | 0 | 0 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please manually update alequetzalli
to her new login https://github.com/quetzalliwrites
TSC_VOTING_OVERVIEW.md
Outdated
| [anshgoyalevil](https://github.com/anshgoyalevil) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | 2024-06-03 | true | 2024-06-14 | 2 | 0 | 0 | 1 | | ||
| [anandsunderraman](https://github.com/anandsunderraman) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | 2024-06-13 | true | 2024-06-14 | 2 | 0 | 0 | 1 | | ||
| [Shurtu-gal](https://github.com/Shurtu-gal) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | 2024-05-28 | true | 2024-06-14 | 3 | 0 | 0 | 0 | | ||
| [cameronrushton](https://github.com/cameronrushton) | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | Member has not participated in all previous voting process. | Member has not participated in all previous voting process. | 2024-06-14 | 0 | 0 | 0 | 3 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry but you need to do some updates to script, reported data is wrong
he was the first one I checked and he is visible in #1227 as abstain
you'll have to manually review if reported data is accurate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we have it all, great job!!!
and once we close voting on #1313 we will be able to test how updating of data works
/rtm |
Resolve: #1268
VotingTracking Structure:
Format: https://github.com/AayushSaini101/Vote/blob/main/voteTrackingDetails.md