Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add new worklow to track the voting process #1278

Merged
merged 60 commits into from
Jul 23, 2024

Conversation

AayushSaini101
Copy link
Contributor

@AayushSaini101 AayushSaini101 commented Jun 17, 2024

Resolve: #1268

  • Added new workflow to track the voting history of every TSC member.
    VotingTracking Structure:

Format: https://github.com/AayushSaini101/Vote/blob/main/voteTrackingDetails.md

@asyncapi-bot-eve
Copy link
Contributor

Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process

@AayushSaini101
Copy link
Contributor Author

AayushSaini101 commented Jun 17, 2024

Status: for testing
https://github.com/AayushSaini101/Vote/blob/main/VoteTracking.json VotingTracking.json File updated

@asyncapi-bot-eve
Copy link
Contributor

Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process

@AayushSaini101
Copy link
Contributor Author

AayushSaini101 commented Jun 21, 2024

@derberg as suggested in the requirements here is the sample https://github.com/AayushSaini101/Vote/blob/main/voteTrackingDetails.md, The workflow first create two files that is voteTracking.json and voteTrackingDetails.md. The json file is used to parse the requests frequently
image
Ready for the review :)

@asyncapi-bot-eve
Copy link
Contributor

Hi @AayushSaini101, since you are not a TSC Member, you cannot start or stop voting. Please read more about voting process

@AayushSaini101
Copy link
Contributor Author

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some initial comments

.github/workflows/vote-tracker.yml Show resolved Hide resolved
- name: Run vote tracker script
id: vote_tracker
if: |
github.event.comment.user.login == 'git-vote[bot]' &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we have this login validation on a job level, to basically not run entire job if this was not met? case with comment body

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @derberg

.github/workflows/vote-tracker.yml Outdated Show resolved Hide resolved
.github/workflows/vote-tracker.yml Outdated Show resolved Hide resolved
voting.md Outdated Show resolved Hide resolved
voting.md Outdated Show resolved Hide resolved
.github/scripts/vote_tracker.js Outdated Show resolved Hide resolved
.github/scripts/vote_tracker.js Outdated Show resolved Hide resolved
@AayushSaini101
Copy link
Contributor Author

@derberg I have added one more value for the isVotedInLast3Months column that is Member has not participated in all previous voting process. . We are using only true and false this values seems giving false information who has not participated in the first, second vote, in that case we can use Member has not participated in all previous voting process.

Sample: https://github.com/AayushSaini101/Vote/blob/main/TSC_VOTING_OVERVIEW.md

@aeworxet
Copy link
Contributor

@asyncapi/bounty_team

voteTrackingFile.json Outdated Show resolved Hide resolved
voting.md Outdated Show resolved Hide resolved
AayushSaini101 and others added 4 commits July 22, 2024 16:53
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
@AayushSaini101
Copy link
Contributor Author

@derberg Done: Added md file as well in the starting added comment in md as well as in the md file generator

voting.md Outdated Show resolved Hide resolved
Co-authored-by: Lukasz Gornicki <lpgornicki@gmail.com>
| [Amzani](https://github.com/Amzani) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | 2024-06-13 | true | 2024-06-14 | 2 | 0 | 0 | 1 |
| [smoya](https://github.com/smoya) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | 2024-05-28 | true | 2024-06-14 | 2 | 0 | 0 | 1 |
| [souvikns](https://github.com/souvikns) | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | Member has not participated in all previous voting process. | Member has not participated in all previous voting process. | 2024-06-14 | 0 | 0 | 0 | 3 |
| [alequetzalli](https://github.com/alequetzalli) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | 2024-06-04 | true | 2024-06-14 | 3 | 0 | 0 | 0 |
Copy link
Member

@derberg derberg Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please manually update alequetzalli to her new login https://github.com/quetzalliwrites

| [anshgoyalevil](https://github.com/anshgoyalevil) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | 2024-06-03 | true | 2024-06-14 | 2 | 0 | 0 | 1 |
| [anandsunderraman](https://github.com/anandsunderraman) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | 2024-06-13 | true | 2024-06-14 | 2 | 0 | 0 | 1 |
| [Shurtu-gal](https://github.com/Shurtu-gal) | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | <span style="position: relative; cursor: pointer;" title="In favor">👍</span> | 2024-05-28 | true | 2024-06-14 | 3 | 0 | 0 | 0 |
| [cameronrushton](https://github.com/cameronrushton) | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | <span style="position: relative; cursor: pointer;" title="Not participated">🔕</span> | Member has not participated in all previous voting process. | Member has not participated in all previous voting process. | 2024-06-14 | 0 | 0 | 0 | 3 |
Copy link
Member

@derberg derberg Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry but you need to do some updates to script, reported data is wrong

he was the first one I checked and he is visible in #1227 as abstain

you'll have to manually review if reported data is accurate

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we have it all, great job!!!

and once we close voting on #1313 we will be able to test how updating of data works

@derberg
Copy link
Member

derberg commented Jul 23, 2024

/rtm

@asyncapi-bot asyncapi-bot merged commit 39e05c2 into asyncapi:master Jul 23, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging this pull request may close these issues.

Report on each completed voting the TSC participation
5 participants