Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download wheel to disk when streaming unzip failed with HTTP streaming error #5094

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Download wheel to disk when streaming unzip failed with HTTP streaming error #5094

merged 2 commits into from
Jul 16, 2024

Conversation

messense
Copy link
Contributor

@messense messense commented Jul 16, 2024

Summary

Workaround the stream_wheel not retry issue found in #3514, it's not a perfect solution but I think it's acceptable because the error should not occur frequently.

Test Plan

Manually using iptables -A OUTPUT -p tcp -dport 3128 -j REJECT --reject-with tcp-reset to inject connection reset error to the HTTP proxy that proxies PyPI requests.

error: Failed to prepare distributions
  Caused by: Failed to fetch wheel: piqp==0.4.1
  Caused by: Request failed after 3 retries
  Caused by: error sending request for url (https://files.pythonhosted.org/packages/94/4d/09ade94dfda5b57c1ca43564541871bd1a0d89dfd3c368ac505b6ca09831/piqp-0.4.1-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl)
  Caused by: client error (Connect)
  Caused by: tcp connect error: Connection refused (os error 111)
  Caused by: Connection refused (os error 111)

@konstin konstin added bug Something isn't working network Network connectivity e.g. proxies, DNS, and SSL labels Jul 16, 2024
@charliermarsh charliermarsh merged commit 38504dc into astral-sh:main Jul 16, 2024
51 checks passed
@messense messense deleted the retry-http-streaming-error branch July 16, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working network Network connectivity e.g. proxies, DNS, and SSL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants