You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently lint and fix python files and jupyter notebook but only format python files.
Formatting jupyter notebooks can reuse the infrastructure we use to lint and fix them, it should mostly be a matter of formatting each cell in a loop (being mindful of leading and trailing newlines) and adding a test.
The text was updated successfully, but these errors were encountered:
## Summary
This PR enables `ruff format` to format Jupyter notebooks.
Most of the work is contained in a new `format_source` method that
formats a generic `SourceKind`, then returns `Some(transformed)` if the
source required formatting, or `None` otherwise.
Closes#7598.
## Test Plan
Ran `cat foo.py | cargo run -p ruff_cli -- format --stdin-filename
Untitled.ipynb`; verified that the console showed a reasonable error:
```console
warning: Failed to read notebook Untitled.ipynb: Expected a Jupyter Notebook, which must be internally stored as JSON, but this file isn't valid JSON: EOF while parsing a value at line 1 column 0
```
Ran `cat Untitled.ipynb | cargo run -p ruff_cli -- format
--stdin-filename Untitled.ipynb`; verified that the JSON output
contained formatted source code.
We currently lint and fix python files and jupyter notebook but only format python files.
Formatting jupyter notebooks can reuse the infrastructure we use to lint and fix them, it should mostly be a matter of formatting each cell in a loop (being mindful of leading and trailing newlines) and adding a test.
The text was updated successfully, but these errors were encountered: