Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong fingerprint in Gitlab format #3441

Closed
Agalin opened this issue Mar 10, 2023 · 2 comments · Fixed by #3456
Closed

Wrong fingerprint in Gitlab format #3441

Agalin opened this issue Mar 10, 2023 · 2 comments · Fixed by #3456
Labels
bug Something isn't working

Comments

@Agalin
Copy link

Agalin commented Mar 10, 2023

Ruff version: 0.0.253

Gitlab Code Quality formatter sets fingerprint to a code of the issue, e.g. F401.

But this field should be a unique value identifying a single violation, not its type. As a consequence, multiple violations of the same type are not visible (only the last one is shown).

It makes the feature unusable, for a project with currently 120 violations Gitlab only shows 7 (as there are 7 unique types of violations).

@Agalin
Copy link
Author

Agalin commented Mar 10, 2023

Just checked and it's not possible to work around this using external tools - report doesn't provide column position which means that it's not possible to distinguish multiple issues with the same description in the same line.

@charliermarsh
Copy link
Member

Makes sense, thanks for filing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants