UP024 removes non-OSError exception

[charliermarsh]

Found a false positive one:

My code:

import socket
...
from kombu import Connection, exceptions

...

try:
    conn = Connection(settings.CELERY_BROKER_URL)
    conn.ensure_connection(max_retries=2)
    conn._close()
except (socket.error, exceptions.OperationalError):
    return HttpResponseServerError("cache: cannot connect to broker.")

their MROs:

exceptions.OperationalError.__mro__
(<class 'kombu.exceptions.OperationalError'>, <class 'kombu.exceptions.KombuError'>, <class 'Exception'>, <class 'BaseException'>, <class 'object'>)

socket.error.__mro__
(<class 'OSError'>, <class 'Exception'>, <class 'BaseException'>, <class 'object'>)

ruff suggests:

try:
    conn = Connection(settings.CELERY_BROKER_URL)
    conn.ensure_connection(max_retries=2)
    conn._close()
except OSError:
    return HttpResponseServerError("cache: cannot connect to broker.")

Seems like ruff ignores the second one's MRO. Thank you!

Originally posted by @deliro in #1568 (comment)