This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Optimize output size of kpm pack #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,6 +14,7 @@ public class GlobalSettings | |||
|
|
|||
| public IList<string> SourcePaths { get; private set; } | |||
| public string PackagesPath { get; private set; } | |||
| public IDictionary<Library, string> LibrarySHAs { get; private set; } | |||
|
@davidfowl , changed based on feedbacks. Also implemented the idea mentioned by you and @lodejard last Friday and successfully reduced the number of |
| var library = new Library() | ||
| { | ||
| Name = property.Name, | ||
| Version = SemanticVersion.Parse(dependencies[property.Name]["version"].ToString()) |
There was a problem hiding this comment.
We need to be more defensive here.
|
|
ChengTian
force-pushed
the
optimize-output-size-of-kpm-pack
branch
from
3355b19
to
78c8ec3
Compare
- Nupkgs, nuspecs and SHA files are not copied to output packages folder - Only copy assemblies needed by the frameworks being packed with - Use frameworks in project.json if '--runtime' was not specified - Use values of '--runtime' to filter frameworks in project.json - Use SHAs from global.json when resolving KRE_PACKAGES_CACHE - Copy tools dlls from source packages to bin folder of output
ChengTian
force-pushed
the
optimize-output-size-of-kpm-pack
branch
from
78c8ec3
to
7119cb3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parent #652