Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

PageActionDescriptorChangeProvider does not invalidate the cache when a _PageStart outside of RazorPagesOption.BasePath is modified #5915

Closed
pranavkm opened this issue Mar 7, 2017 · 3 comments

Comments

@pranavkm
Copy link
Contributor

pranavkm commented Mar 7, 2017

The PageActionDescriptorProvider caches _PageStart factories and is invalidated when PageActionDescriptorChangeProvider is modifed.

/_PageStart.cshtml
/Pages                        <- BasePath
   /Index.cshtml

However, it specifically watches for cshtml files under the BasePath directory. This might miss changes to _PageStart items outside the BasePath.

@rynowak
Copy link
Member

rynowak commented Mar 7, 2017

IMO that /_PageStart.cshtml should be totally ignored.

@rynowak
Copy link
Member

rynowak commented Mar 7, 2017

I'm running into a related issue where a _PageStart in the same folder isn't even found.

services.AddMvc().AddRazorPagesOptions(options => options.RootDirectory = "/Pages");

Makes my /Pages/_PageStart.cshtml be totally ignored.

@rynowak
Copy link
Member

rynowak commented Mar 7, 2017

@pranavkm - assigning to you to figure out. Please treat this as a dogfood blocker (and add a functional test).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants