Skip to content
This repository has been archived by the owner on Nov 2, 2018. It is now read-only.

Remove use of IConfiguration from ServiceCollection #116

Closed
halter73 opened this issue Oct 8, 2014 · 0 comments
Closed

Remove use of IConfiguration from ServiceCollection #116

halter73 opened this issue Oct 8, 2014 · 0 comments

Comments

@halter73
Copy link
Member

halter73 commented Oct 8, 2014

AddMvc, AddSignalR, GetDefaultServices, etc... already take in an IConfiguration object and use a ServiceDescriber to pull in replacement service implementations from config.

If you were to create your own ServiceCollection (which is atypical) and pass in an IConfiguration object to the constructor, it would not be respected by AddMvc and family.

For these reasons, we should remove the constructor from ServiceCollection that accepts an IConfiguration object, and stop using ServiceDescriber in ServiceCollection since it doesn't provide as much utility when an IConfiguration object is provided.

pranavkm added a commit that referenced this issue Oct 17, 2014
* Remove use of IConfiguration from ServiceCollection
* Removing the Add* methods from IServiceCollection that don't accept an
  IServiceDescriptor

Fixes #116 #117
pranavkm added a commit that referenced this issue Oct 20, 2014
* Remove use of IConfiguration from ServiceCollection
* Removing the Add* methods from IServiceCollection that don't accept an
  IServiceDescriptor

Fixes #116 #117
pranavkm added a commit that referenced this issue Oct 21, 2014
* Remove use of IConfiguration from ServiceCollection
* Removing the Add* methods from IServiceCollection that don't accept an
  IServiceDescriptor

Fixes #116 #117
@Eilon Eilon added this to the 1.0.0-beta1 milestone Oct 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants