Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better documentation around passing options to Kroki #449

Open
jaskij opened this issue Apr 12, 2024 · 1 comment
Open

Better documentation around passing options to Kroki #449

jaskij opened this issue Apr 12, 2024 · 1 comment
Labels
👶 good first issue Good for newcomers 📖 documentation 👋 help wanted

Comments

@jaskij
Copy link

jaskij commented Apr 12, 2024

I came here to open an issue similar to #418. Reading through the comments under it, specifically #418 (comment), it turns out that unknown named attributes are just passed through to Kroki as diagram options.

Perhaps this is present in the README, but never stated explicitly.
@ggrossetie
Copy link
Member

I came here to open an issue similar to #418. Reading through the comments under it, specifically #418 (comment), it turns out that unknown named attributes are just passed through to Kroki as diagram options.

Perhaps this is present in the README, but never stated explicitly.

I agree, we should add this information. Feel free to open a pull request to add a section about it in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
👶 good first issue Good for newcomers 📖 documentation 👋 help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ggrossetie @jaskij