-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recursive remote includes does not work in the preprocessor #398
Comments
I could provide more logs or information if somebody tells me how to do the troubleshooting to actually get that data. |
Could you please share your diagram? Or a diagram that reproduces this error? |
@Mogztter here is the diagram causing the issue (anonymized but exactly the same size):
|
It's more portable to use
Diagram are not encoded when using POST requests, the content is sent in the JSON payload.
If you have |
Oh I did not know about this include syntax. And apparently it is related to the include... Also I can see that actually all my graphs are sent using POST and only my the one with |
Kroki does not resolve remote includes for security reasons, that's why
The extension will (be default) use a POST request if the URI length is longer than |
All My graphs are smaller than 4000 bytes (and sent using GET) now that I changed then all to This is why I asked if asciidoctor-kroki is resolving includes locally before sending them to the kroki server. There is something really weird happening. |
Yes, the preprocessor will replace That's probably why the size was > 4000 bytes. |
There is nearly nothing in the logs of kroki, only that the function My guess is that |
Sorry wrong click... |
Recursive local include works but maybe recursive remote include does not 🤔 |
I have a documentation using antora, dozens of diagrams. Only a single diagram is not rendered.
In the antora debug logs I only get a single message:
Sadly in the current setup I have no more logs. To get what happens in kroki I would need to setup a local kroki instance, but I expect it to be an encoding error when POSTing the diagram source since it works for all smaller diagrams.
The kroki returns an SVG if I POST the diagram source it manually using:
The text was updated successfully, but these errors were encountered: