-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to configure the criticality when an include is missing #147
Comments
This just bit me again. the fix of putting in
compiles correctly, as mentioned in my bug (#49). but, the
line is dumped into just mentioning because it just ground me to a halt for the moment. |
Would it be possible that (asciidoctor-)kroki support a special comment in the PlantUML diagram itself? This could solve the problem with plantuml-stdlib/C4-PlantUML#156 if I would add a line like
BR Helmut |
Indeed, In this case, I think we should use
I'm not sure... maybe... 🤔 |
But maybe I'm missing something? These error messages does not format like the other Antora log messages:
Maybe something more has to be done to send the logs through Antora logger? |
We are using I also think that some logs are too pedantic... It's hard to find the right balance 😬 |
I've decided to reduce the severity from warn to info. I think we should manage the criticality using the logger level. |
Seem like a good solution in #324 👍 |
We might want to introduce an attribute to control the criticality when an include is missing:
kroki-plantuml-unresolved-local-include
warn
: log a warningerror
: throw an exceptionignore
(orsuppress
): silently ignoreWe could do the same for remote include. The default value of local include would be error and the default value for remote include would be warn.
Follow-up #141
The text was updated successfully, but these errors were encountered: