Temp Fix - PHPUnit 9 #308
Merged
Temp Fix - PHPUnit 9 #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinicius73 Can you review this request primarily? I have added it because PHPUnit updated to version 10; that makes all our automated checks fail since they are based on version 9. This merge pins PHPUnit to version 9 for now; while I'm preparing the merge for version 10 in #306 . After this v9 has been fixed; #304 and #297 should be able to be merged so please review if they can be done after this merge. |
|
@vinicius73 Normally I wait for you to do the final review of the PR before merging but since this is a very minor adjustment & to prevent delay for item #304; I have decided to push ahead and merge this item. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin PHPUnit to version 9; to make sure the automated tests remain operational.