Skip to content
This repository has been archived by the owner on Nov 16, 2021. It is now read-only.

Importing HttpClientModule overwrites existing HTTP_INTERCEPTORS #47

Closed
csomazoli opened this issue Oct 30, 2017 · 2 comments
Closed

Importing HttpClientModule overwrites existing HTTP_INTERCEPTORS #47

csomazoli opened this issue Oct 30, 2017 · 2 comments

Comments

@csomazoli
Copy link

Repro

import InlineSVGModule in a lazy loaded module (I'm not sure it affects only lazy loaded ones), when HTTP_INTERCEPTORS are provided, and HttpClientModule is imported at a higher level (for example, in the root app module).

Issue

InlineSVGModule imports HttpClientModule. Doing so overwrites existing HTTP_INTERCEPTORS.
According to angular docs, HttpClientModule should be imported only in the root module of the application.

I know your module relies on HttpClientModule, but instead of importing it yourself, you should leave it to the users to import it, so this way HTTP_INTERCEPTORS won't be overwritten.

@arkon arkon closed this as completed in 0869f36 Oct 30, 2017
@arkon
Copy link
Owner

arkon commented Oct 30, 2017

Changed in v5.0.0.

@csomazoli
Copy link
Author

Wow, thanks for the quick response!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants