-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Actually use precomputed witness #932
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
!gpu-benchmark |
Benchmark for 08da70dClick to view benchmark
|
!gpu-benchmark |
Benchmark for 08da70dClick to view benchmark
|
arthurpaulino
force-pushed
the
use-cached-witness-2
branch
from
November 30, 2023 10:01
fb043a5
to
ebba186
Compare
arthurpaulino
force-pushed
the
use-cached-witness-2
branch
2 times, most recently
from
December 1, 2023 11:07
5f5e8d1
to
c3a312d
Compare
arthurpaulino
force-pushed
the
use-cached-witness-2
branch
from
December 1, 2023 15:25
c3a312d
to
2624994
Compare
huitseeker
reviewed
Dec 1, 2023
!gpu-benchmark |
Benchmark for 86b5844Click to view benchmark
|
huitseeker
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a second attempt after the failure of #928 (reverted in #931).
#928 was returning the wrong output because LEM doesn't allocate the output at the end.
So this PR allows
MultiFrameTrait
implementers to cache their witnesses internally, using whichever data format they want. LEM'sMultiFrame
does so by caching theWitnessCS
and the output (the vector of allocated numbers).With that available, LEM can now make proper use of cached witnesses.