Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Switch to reusable bench-deploy.yml #1164

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samuelburnham
Copy link
Member

  • Adds historical benchmark plots via reusable bench-deploy.yml workflow, described in Fix bench-deploy.yml action ci-workflows#44
  • Refactors Fibonacci benchmark env configuration
    • Groups benchmarks by fib_n input rather than rc, which allows for a more natural comparison for each of our output types. For example this means in gh-pages we will have one plot per Fib input and one line per RC value, which means different RC performance can be compared directly.
    • Changes the LURK_RC env var to LURK_BENCH_RC to clarify its usage in benchmarks and bench-like examples only
    • Adds the LURK_BENCH_FIBN env var to configure Fibonacci input values as desired (e.g. in a PR comment benchmark)

Note

Needs further testing once merged

@samuelburnham samuelburnham requested review from a team as code owners February 21, 2024 19:23
@samuelburnham
Copy link
Member Author

!benchmark --bench fibonacci --features cuda

Copy link
Contributor

Benchmark for 359e6a1

Click to view benchmark
Test Base PR %
Fibonacci Prove - num = 100/fib/rc-100 1457.9±9.98ms N/A N/A
Fibonacci Prove - num = 200/fib/rc-100 2.8±0.01s N/A N/A
LEM Fibonacci Prove - rc = 100/fib/num-100 1441.7±7.10ms N/A N/A
LEM Fibonacci Prove - rc = 100/fib/num-200 2.8±0.01s N/A N/A
LEM Fibonacci Prove - rc = 600/fib/num-100 1835.5±13.52ms N/A N/A
LEM Fibonacci Prove - rc = 600/fib/num-200 3.0±0.02s N/A N/A

@samuelburnham samuelburnham marked this pull request as draft February 22, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant