-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extend callables #1163
Merged
Merged
feat: extend callables #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurpaulino
force-pushed
the
ap/extend-callable
branch
2 times, most recently
from
February 21, 2024 20:07
6c66a49
to
08e3efc
Compare
arthurpaulino
force-pushed
the
ap/extend-callable
branch
from
February 21, 2024 20:45
08e3efc
to
7a5078c
Compare
porcuquine
previously approved these changes
Feb 21, 2024
arthurpaulino
force-pushed
the
ap/extend-callable
branch
4 times, most recently
from
February 21, 2024 22:30
ae3d7d7
to
0c36057
Compare
huitseeker
previously approved these changes
Feb 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving to unblock: the changes post @porcuquine review are just re-organizing tests.
arthurpaulino
force-pushed
the
ap/extend-callable
branch
from
February 22, 2024 16:02
0c36057
to
e69e35c
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 22, 2024
arthurpaulino
force-pushed
the
ap/extend-callable
branch
from
February 22, 2024 17:10
e69e35c
to
018ba52
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 22, 2024
* exclude tests that can no longer be satisfied due to this change * adapt `test_prove_head_with_sym_mimicking_value`
arthurpaulino
force-pushed
the
ap/extend-callable
branch
from
February 22, 2024 17:55
018ba52
to
2ba0283
Compare
huitseeker
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1159