This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
feat: wait for detached aria-busy #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
gregberge
suggested changes
Jul 19, 2023
| @@ -76,7 +76,7 @@ export async function argosScreenshot( | |||
| await page.addStyleTag({ content: GLOBAL_STYLES }); | |||
|
|
|||
| // Wait for all busy elements to be loaded | |||
| await page.waitForSelector('[aria-busy="true"]', { state: "hidden" }); | |||
| await page.waitForSelector('[aria-busy="true"]', { state: "detached" }); | |||
There was a problem hiding this comment.
This is not what we want here. A "display: none" aria-busy does not count so "state: hidden" is the good one.
There was a problem hiding this comment.
Please read my PR description, above
There was a problem hiding this comment.
Ok, I think this fix is not good. It will break things. But did we have some 0x0px aria-busy in Pivot? I think not.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, the state option for waitForSelector is changed from
hiddentodetached. Here's the key difference:Why this change?
With Playwright, an empty div isn't considered visible, which is a problem for users using empty div with
aria-busyto delay the screenshot capture.