Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] argilla server: add basic endpoints telemetry support #5437

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Aug 28, 2024

Description

This PR adds a middleware component to track the API endpoint's usage.

Type of change

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@frascuchon frascuchon marked this pull request as draft August 28, 2024 11:34
@frascuchon frascuchon changed the title [Feat] argilla server: add general endpoints telemetry support [FEAT] argilla server: add general endpoints telemetry support Aug 28, 2024
@frascuchon frascuchon force-pushed the feat/argilla-server/add-general-endpoints-telemetry-support branch from ec5a087 to 575b8f9 Compare August 28, 2024 14:57
@frascuchon frascuchon marked this pull request as ready for review August 28, 2024 14:57
@frascuchon frascuchon changed the title [FEAT] argilla server: add general endpoints telemetry support [FEAT] argilla server: add basic endpoints telemetry support Aug 28, 2024
argilla-server/src/argilla_server/_app.py Outdated Show resolved Hide resolved
argilla-server/src/argilla_server/_app.py Show resolved Hide resolved
argilla-server/src/argilla_server/_app.py Outdated Show resolved Hide resolved
argilla-server/src/argilla_server/_app.py Outdated Show resolved Hide resolved
argilla-server/src/argilla_server/_app.py Outdated Show resolved Hide resolved
frascuchon and others added 4 commits August 30, 2024 09:07
Co-authored-by: José Francisco Calvo <jose@argilla.io>
…port' of github.com:argilla-io/argilla into feat/argilla-server/add-general-endpoints-telemetry-support
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 96.15385% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.60%. Comparing base (62b1c12) to head (8d012a8).
Report is 94 commits behind head on feat/5204-feature-add-huggingface_hubutilssend_telemetry-to-the-argilla-server.

Files with missing lines Patch % Lines
argilla-server/src/argilla_server/_app.py 87.50% 2 Missing ⚠️
argilla-server/src/argilla_server/telemetry.py 96.66% 1 Missing ⚠️
Additional details and impacted files
@@                                                Coverage Diff                                                 @@
##           feat/5204-feature-add-huggingface_hubutilssend_telemetry-to-the-argilla-server    #5437      +/-   ##
==================================================================================================================
+ Coverage                                                                           91.13%   91.60%   +0.47%     
==================================================================================================================
  Files                                                                                 139      140       +1     
  Lines                                                                                5716     5994     +278     
==================================================================================================================
+ Hits                                                                                 5209     5491     +282     
+ Misses                                                                                507      503       -4     
Flag Coverage Δ
argilla-server 91.60% <96.15%> (+0.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon force-pushed the feat/argilla-server/add-general-endpoints-telemetry-support branch from a1c8c4e to bcfcf4f Compare September 2, 2024 07:58
@frascuchon frascuchon merged commit f0019cc into feat/5204-feature-add-huggingface_hubutilssend_telemetry-to-the-argilla-server Sep 2, 2024
6 checks passed
@frascuchon frascuchon deleted the feat/argilla-server/add-general-endpoints-telemetry-support branch September 2, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants