[FEATURE] [SERVER] chat field support server #5377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
...tests/unit/api/handlers/v1/datasets/records/records_bulk/test_create_dataset_records_bulk.py
Show resolved
Hide resolved
Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
…rgilla-io/argilla into feat/chat-field-support-server
for more information, see https://pre-commit.ci
argilla-server/tests/unit/api/handlers/v1/datasets/fields/test_list_dataset_fields.py
Show resolved
Hide resolved
| @@ -40,6 +40,7 @@ | |||
| "image/svg", | |||
| "image/webp", | |||
| ] | |||
| CHAT_FIELD_MAX_LENGTH = 500 | |||
There was a problem hiding this comment.
should we add these to general constants.py?
There was a problem hiding this comment.
Personally, I find local constants easier to read and maintain.
There was a problem hiding this comment.
Me too normally but otherwise it ends up being fragmented, right?
...tests/unit/api/handlers/v1/datasets/records/records_bulk/test_create_dataset_records_bulk.py
Show resolved
Hide resolved
Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
davidberenstein1957
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for a chat field to the server.
Type of change
How Has This Been Tested
Tests are updated
Checklist