[ENHANCEMENT] argilla server: Add support for filter on list datasets
#5374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
changed the title
argilla server: Aadd support for filter on list datasetsargilla server: Add support for filter on list datasets
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5374 +/- ##
===========================================
- Coverage 91.00% 90.97% -0.04%
===========================================
Files 144 144
Lines 5915 5914 -1
===========================================
- Hits 5383 5380 -3
- Misses 532 534 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…r-on-list-datasets
jfcalvo
requested changes
Sep 3, 2024
argilla-server/tests/unit/api/handlers/v1/datasets/test_list_user_datasets.py
Outdated
Show resolved
Hide resolved
argilla-server/tests/unit/api/handlers/v1/datasets/test_list_user_datasets.py
Outdated
Show resolved
Hide resolved
argilla-server/tests/unit/api/handlers/v1/datasets/test_list_user_datasets.py
Outdated
Show resolved
Hide resolved
argilla-server/tests/unit/api/handlers/v1/datasets/test_list_user_datasets.py
Outdated
Show resolved
Hide resolved
argilla-server/tests/unit/api/handlers/v1/datasets/test_list_user_datasets.py
Outdated
Show resolved
Hide resolved
argilla-server/tests/unit/api/handlers/v1/datasets/test_list_user_datasets.py
Outdated
Show resolved
Hide resolved
…r-on-list-datasets
jfcalvo
reviewed
Sep 17, 2024
Co-authored-by: José Francisco Calvo <jose@argilla.io>
jfcalvo
approved these changes
Sep 18, 2024
…r-on-list-datasets
frascuchon
deleted the
feat/argilla-server/add-support-for-filter-on-list-datasets
branch
Merged
frascuchon
added a commit
that referenced
this pull request
Sep 18, 2024
# Description <!-- Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change. --> After changes from #5374 a test is failing due to mismatched text. This PR fixes it. **Type of change** <!-- Please delete options that are not relevant. Remember to title the PR according to the type of change --> **How Has This Been Tested** <!-- Please add some reference about how your feature has been tested. --> **Checklist** <!-- Please go over the list and make sure you've taken everything into account --> - I added relevant documentation - I followed the style guidelines of this project - I did a self-review of my code - I made corresponding changes to the documentation - I confirm My changes generate no new warnings - I have added tests that prove my fix is effective or that my feature works - I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/) --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds filter support to list user datasets endpoint. The endpoint allows filterirng by
statusandname. This can be used by clients when filtering by datasets.Type of change
How Has This Been Tested
Checklist