Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] argilla: add support to create image fields #5372

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Aug 2, 2024

Description

This PR adds support to work with image fields using the SDK.

TODO (as separate PRs)

  • Add documentation section
  • Verify behavior using from/to_hub methods
  • Add tooling to read data URLs from image files/folders (based on logic defined in image_to_html)
  • Add some media type validation (supported image types)
  • [Optional] Add tooling to re-scale images. The lower the image sizes, the better the UI work. We can define a transparent re-scaling process to support large images (currently the limit size in the backend is 5MB for data URL)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@burtenshaw burtenshaw merged commit 7e5136d into feat/add-image-field-support Aug 6, 2024
13 checks passed
@burtenshaw burtenshaw deleted the feat/argilla/add-support-to-create-image-fields branch August 6, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants