Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Add integration with
huggingface_hub.utils.telemetry
#5218[FEAT] Add integration with
huggingface_hub.utils.telemetry
#5218Changes from 58 commits
431f296
2d4aef4
71cf614
e1924e4
11a1f85
9adfc16
0109e44
038d8f6
dbcebdc
5581837
9d7316d
01d8af7
cea525c
aa9c6ca
b694ce1
ebf139e
fc2055c
77dd130
6979112
9bffe18
e6763cc
a94ab7c
a6f7c0f
a70c590
d762dc3
4addc7b
ac7601c
c72c4b0
538c268
0b167eb
4fcbbd6
8428939
daea0b2
18c5d0f
0230bfa
cbacf35
2473c82
35c9e43
df9a0fc
c64cc29
8b0c752
0ed746b
fef47b8
b982497
e332696
a1c83a1
17b0403
f6e9f38
68d6e53
de181a9
b823e2e
bb2dfd5
cad43a1
5fd9492
659d9a2
c725352
93d46b1
f5901b9
f0019cc
43ef896
8ce3621
c7c22f8
32f3baa
0c9c608
00b6caa
942455d
0b825a0
d93c27b
cd45e6b
0c51124
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know how these telemetry requests are done? Are they synchronous? UDP?
We should check that we are not spending a lot of time executing these requests so we are not adding additional time to the API endpoint requests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jfcalvo underlying code can be found here. https://github.com/huggingface/huggingface_hub/blob/main/src/huggingface_hub/utils/_telemetry.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not "publish" instead of "create" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fine by me, I wanted to align things as much as possible within the same topic URLs, but I will differentiate a bit more and potentially also create a separate one for "list".