-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial version of deploy_on_spaces
#5158
Add initial version of deploy_on_spaces
#5158
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is useful functionality, but I'm not sure that it needs to be in the sdk because it will introduce maintenance challenges. As you mention in the comment: oauth, testing.
Instead, could this be an example of the first extension?
it would fit quite nicely in a "huggingface spaces sdk" , which is something to look forward to |
@burtenshaw not sure why the OAuth is an issue. I thought of adding it as an extra but I think the value of the integration also lies in the fact that it works on the fly as an entry point so I would then propose showing it on import or function execution instead of mentioning it everywhere through the docs. WDYT? |
@frascuchon |
Sorry. I didn't explain this point properly. I meant that oauth, and other challenges, could increase the complexity of the module and so might be better placed in another package. That said, I'm not 100% against this inclusion in the SDK. But I do think it's a significant change that we should find the best place for. My main concern is that we end up with too much utilities code in the SDK that's difficult to maintain on a daily basis. And doesn't offer much value to the user beyond a well documented Spaces deployment guide. If we do include this in the SDK, rather than an extension, I'd say that we should interface it consistently with the But, I'd like to also here from @frascuchon and @dvsrepo . |
@Josephrp what's the latest on this? |
The official is this one: https://huggingface.co/spaces/argilla/argilla-template-space (the one that is used by the New Space UI HF flow too). The other one is an unofficial one I created to be able to launch oauth spaces more easily |
@dvsrepo @burtenshaw and I decided to go forward with this. @frascuchon do you have any specific opinion about the PR and location of the |
@davidberenstein1957 Is this ready to go into |
Pull Request Template
Add default deployment options for Hugging Face spaces through the Hugging Face hub api.
Closes #5108
DeploymentMixin
class within_deploy.py
within_helpers
directoryhuggingface_hub
as core dependency under the assumption it is lightweight and we will soon use it for telemetry too.TODO:
argilla
vsargilla-space-with-oauth
@frascuchon do you know what the difference is when using these templates?Usage:
Type of change
How Has This Been Tested
Checklist