Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conditional checking SQLite connection so connection configuration is correctly executed #5149

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

jfcalvo
Copy link
Member

@jfcalvo jfcalvo commented Jul 3, 2024

Description

After changing SQLite connection to be asynchronous on version 1.14.0 using aiosqlite. There was a type check that was not changed and causing the connection configuration to not be executed for SQLite.

This PR fix the type check so the configuration statements are correctly executed and add a test to check for the expected values.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested

  • Manually testing it with SQLite.

Checklist

  • I added relevant documentation
  • follows the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • I confirm My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@jfcalvo jfcalvo requested a review from frascuchon July 3, 2024 11:54
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.94%. Comparing base (92a3dd6) to head (844afaf).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5149   +/-   ##
========================================
  Coverage    91.93%   91.94%           
========================================
  Files          135      135           
  Lines         5818     5819    +1     
========================================
+ Hits          5349     5350    +1     
  Misses         469      469           
Flag Coverage Δ
argilla-server 91.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jfcalvo jfcalvo merged commit c1405d2 into develop Jul 4, 2024
2 checks passed
@jfcalvo jfcalvo deleted the fix/error-with-set-sqlite-pragma-not-working branch July 4, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants