[REFACTOR] Redefine some property methods #5114

frascuchon · 2024-06-26T14:06:55Z

Type of change

How Has This Been Tested

Checklist

I added relevant documentation
follows the style guidelines of this project
I did a self-review of my code
I made corresponding changes to the documentation
I confirm My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

argilla/src/argilla/_api/_client.py

argilla/src/argilla/client.py

frascuchon changed the base branch from develop to refactor/avoid-autofetch-when-accessing-settings June 26, 2024 14:07

frascuchon requested a review from burtenshaw June 26, 2024 14:07

frascuchon commented Jun 26, 2024

View reviewed changes

argilla/src/argilla/_api/_client.py Show resolved Hide resolved

frascuchon commented Jun 26, 2024

View reviewed changes

argilla/src/argilla/_api/_client.py Show resolved Hide resolved

frascuchon commented Jun 26, 2024

View reviewed changes

argilla/src/argilla/client.py Show resolved Hide resolved

Base automatically changed from refactor/avoid-autofetch-when-accessing-settings to spike/mapping-to-tuple June 27, 2024 08:43

frascuchon marked this pull request as ready for review June 27, 2024 12:59

frascuchon changed the base branch from spike/mapping-to-tuple to develop June 28, 2024 12:15

frascuchon added 3 commits July 1, 2024 11:37

refactor: redefine properties as attribures

8670b2e

refactor: Define me as cached_property

3cf0679

chore: Simplify test setup

abe1bff

frascuchon force-pushed the refactor/redefine-some-property-methods branch from 2cd0e98 to abe1bff Compare July 1, 2024 09:44

burtenshaw approved these changes Jul 3, 2024

View reviewed changes

frascuchon merged commit bcec20e into develop Jul 3, 2024
7 checks passed

frascuchon deleted the refactor/redefine-some-property-methods branch July 3, 2024 13:43

Provide feedback