-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] swap extra_headers for headers in updated sdk docs #5100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFTM! One remark, are we testing this flow somewhere, otherwise we can update it?
No. I could unit test the client attribute. |
6706e1b
to
96705db
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@davidberenstein1957 Thanks for pointing me to testing. On closer inspection I realised that the docs were wrong and we should be using @frascuchon can you confirm this please? |
Yes, @burtenshaw. the Argilla client exposes the httpx.Cient init args in the extra kwargs. Let us add some docs to the Argilla.init describing this (as we do with the APIClient definition |
We already have some unit tests checking this https://github.com/argilla-io/argilla/blob/fix/extra-headers/argilla/tests/unit/api/http/test_http_client.py |
This PR passes the extra headers pass to
Argilla
down to the http client so that argilla sdk can be used with authenticate deployment like provate HF spaces.How Has This Been Tested
Checklist