-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: retrieve user by ID #5044
base: develop
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Thanks @datapumpernickel, could you change the branch to |
@datapumpernickel, would you be able to change the code so we can obtain users either by |
Woopsie, I was trying to change this to the main branch and did not see your reply @davidberenstein1957 in the meantime. Sorry about the mess. |
Hi @datapumpernickel, no problem. Your contribution is great. I think it might be nicer for users to be able to pass either an |
Definitely more convenient to be able to pass both -thanks for the hint. It actually seemed pretty straight forward, to I just put in a commit with a small change that checks if the ID is of instance uuid.UUID, if not, it tries to convert it to an instance of uuid.UUID. It returns an error if that fails for some reason. |
for more information, see https://pre-commit.ci
@datapumpernickel , I realised this had become stale. Sorry for that. Would you be able to resolve the merge conflict? Also, I think the |
Description
Retrieving a user by ID works only when passing in an ID of class UUID. This has been updated in the docs, as well as in the function examples and one error message of the users.py functions.
Closes #5011
How Has This Been Tested
Not tested yet.
Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)