[FEATURE] remove random password generation when creating a user and password is not provided #4993
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burtenshaw
changed the title
burtenshaw
approved these changes
Jun 11, 2024
burtenshaw
reviewed
Jun 11, 2024
| @@ -35,6 +35,11 @@ def test_create_user(self, client: Argilla): | |||
| assert user.id is not None | |||
| assert client.users(username=user.username).id == user.id | |||
|
|
|||
| def test_create_user_without_password(self, client: Argilla): | |||
| user = User(username="test_user") | |||
There was a problem hiding this comment.
Should we also test on retrieving an existing user via client.users("existing_user")
There was a problem hiding this comment.
I added a test with your suggestion. Please can you take a look to it?
frascuchon
approved these changes
Jun 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat/v2.0.0 #4993 +/- ##
===============================================
- Coverage 60.92% 60.90% -0.02%
===============================================
Files 329 329
Lines 17674 17674
===============================================
- Hits 10767 10765 -2
- Misses 6907 6909 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR remove the generation of a random password when a user is created a password is not provided.
With these changes when a user is created and no password is provided a
UnprocessableEntityErrorwill be raised from the backend showing that apasswordattribute must be provided.Closes #4933
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests)Checklist