Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] SDK - Add support for response status #4977

Merged
merged 5 commits into from
Jun 12, 2024

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Jun 7, 2024

Description

This PR adds support to provide the status for record responses. This is quite important to admin users when restoring annotated data from external sources. Also, the migration script from the legacy dataset can benefit the change.

When several statuses are found for the same user before sending data to the server, a warning is shown to the users and the draft status is selected.

Type of change

(Please delete options that are not relevant. Remember to title the PR according to the type of change)

  • New feature (non-breaking change which adds functionality)
  • Refactor (change restructuring the codebase without changing functionality)
  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

(Please describe the tests that you ran to verify your changes. And ideally, reference tests)

  • Test A
  • Test B

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

Also, the inner userRespnose resource manage the whole status based only in provided answers
Copy link
Contributor

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a low comment on warning.

argilla-sdk/src/argilla_sdk/responses.py Show resolved Hide resolved
@frascuchon frascuchon added this to the v2.0.0 milestone Jun 11, 2024
@frascuchon frascuchon force-pushed the feat/sdk/add-support-for-response-status branch from 73448d6 to 6ffdd59 Compare June 11, 2024 09:45
@frascuchon frascuchon force-pushed the feat/sdk/add-support-for-response-status branch from e4db95f to 59a8b94 Compare June 12, 2024 11:04
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (d1bfec6) to head (59a8b94).
Report is 7 commits behind head on feat/v2.0.0.

Additional details and impacted files
@@               Coverage Diff                @@
##           feat/v2.0.0    #4977       +/-   ##
================================================
+ Coverage        60.92%   91.32%   +30.40%     
================================================
  Files              329      136      -193     
  Lines            17674     5833    -11841     
================================================
- Hits             10767     5327     -5440     
+ Misses            6907      506     -6401     
Flag Coverage Δ
argilla ?
argilla-server 91.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frascuchon frascuchon merged commit 279ff4e into feat/v2.0.0 Jun 12, 2024
21 of 23 checks passed
@frascuchon frascuchon deleted the feat/sdk/add-support-for-response-status branch June 12, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants