-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove API v1 dataset records bulk exception captures #4912
Merged
jfcalvo
merged 13 commits into
refactor/improve-api-v1-error-handling
from
refactor/remove-api-v1-dataset-records-bulk-exceptions
Jun 3, 2024
Merged
refactor: remove API v1 dataset records bulk exception captures #4912
jfcalvo
merged 13 commits into
refactor/improve-api-v1-error-handling
from
refactor/remove-api-v1-dataset-records-bulk-exceptions
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frascuchon
approved these changes
May 31, 2024
Base automatically changed from
refactor/remove-api-v1-dataset-records-exceptions
to
refactor/improve-api-v1-error-handling
May 31, 2024 16:53
…emove-api-v1-dataset-records-bulk-exceptions
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## refactor/improve-api-v1-error-handling #4912 +/- ##
==========================================================================
- Coverage 90.97% 90.96% -0.01%
==========================================================================
Files 206 206
Lines 9990 9983 -7
==========================================================================
- Hits 9088 9081 -7
Misses 902 902
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jfcalvo
merged commit Jun 3, 2024
189a7ac
into
refactor/improve-api-v1-error-handling
9 of 10 checks passed
jfcalvo
deleted the
refactor/remove-api-v1-dataset-records-bulk-exceptions
branch
June 3, 2024 09:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR remove all exception capture blocks for API v1 dataset records bulk handler.
Refs #4871
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist