-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Filter record metadata value based on metadata property policies #4906
[BUGFIX] Filter record metadata value based on metadata property policies #4906
Conversation
argilla-server/src/argilla_server/apis/v1/handlers/datasets/records.py
Outdated
Show resolved
Hide resolved
argilla-server/src/argilla_server/apis/v1/handlers/datasets/records.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## releases/1.29.0 #4906 +/- ##
====================================================
+ Coverage 66.65% 90.97% +24.31%
====================================================
Files 399 206 -193
Lines 21935 10117 -11818
====================================================
- Hits 14621 9204 -5417
+ Misses 7314 913 -6401
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only concern is that this change potentially can add a lot of database queries to check for the metadata.
Apart from that it looks good to me.
Description
This PR fixes metadata visibility errors when fetching records for a user.
Type of change
(Please delete options that are not relevant. Remember to title the PR according to the type of change)
How Has This Been Tested
(Please describe the tests that you ran to verify your changes. And ideally, reference
tests
)Checklist
CHANGELOG.md
file (See https://keepachangelog.com/)