Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: small UI improvements #4770

Merged
merged 3 commits into from
May 6, 2024
Merged

feat: small UI improvements #4770

merged 3 commits into from
May 6, 2024

Conversation

leiyre
Copy link
Member

@leiyre leiyre commented May 3, 2024 •
edited
Loading

  • Remove the change of direction in the text labels when hovering ( fix [BUG-UI/UX] Question sign in label flips on hover #4762)
  • Adjust the keyboard key style to high numbers
  • Adjust font size and line height for fields with span question
  • Remove the search placeholder from the entity dropdown

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code severity: minor Indicates that the issue isn't urgent or blocking team: frontend Indicates that the issue or pull request is owned by the frontend team type: improvement Indicates updates or improvements on existing features labels May 3, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4770-ki24f765kq-no.a.run.app

@leiyre leiyre requested a review from damianpumar May 6, 2024 07:02
@damianpumar damianpumar merged commit 3783035 into develop May 6, 2024
13 checks passed
@damianpumar damianpumar deleted the feat/ui-styles-improvement branch May 6, 2024 10:35
damianpumar pushed a commit that referenced this pull request May 7, 2024
@leiyre @damianpumar
feat: small UI improvements (#4770)
7c246de 
- [x] Remove the change of direction in the text labels when hovering (
fix #4762)
- [x] Adjust the keyboard key style to high numbers
- [x] Adjust font size and line height for fields with span question
- [x] Remove the search placeholder from the entity dropdown
sdiazlor added a commit that referenced this pull request May 16, 2024
@sdiazlor
Revert "feat: small UI improvements (#4770)"
8c7a8d4 
This reverts commit 3783035.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damianpumar damianpumar damianpumar approved these changes

Assignees
No one assigned
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code severity: minor Indicates that the issue isn't urgent or blocking size:S This PR changes 10-29 lines, ignoring generated files. team: frontend Indicates that the issue or pull request is owned by the frontend team type: improvement Indicates updates or improvements on existing features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG-UI/UX] Question sign in label flips on hover
2 participants
@leiyre @damianpumar