Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add German translation #4688

Merged
merged 12 commits into from
Apr 3, 2024
Merged

Conversation

paulbauriegel
Copy link
Contributor

@paulbauriegel paulbauriegel commented Mar 28, 2024

Add German translation

I added a i18n translation file for German, because we want to use Argilla in a setting where people only speak that language. Let me know if that would work like that.

Type of change

  • Improvement (change adding some improvement to an existing functionality)

How Has This Been Tested

I only added the i18n translation for German, and checked that the UI works based on the browser setting. Please let me know if there is some test that I would adopt.

Checklist

  • I added relevant documentation
  • I followed the style guidelines of this project
  • I did a self-review of my code
  • I made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I filled out the contributor form (see text above)
  • I have added relevant notes to the CHANGELOG.md file (See https://keepachangelog.com/)

@paulbauriegel paulbauriegel marked this pull request as ready for review March 29, 2024 09:27
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code severity: minor Indicates that the issue isn't urgent or blocking team: frontend Indicates that the issue or pull request is owned by the frontend team type: improvement Indicates updates or improvements on existing features labels Mar 29, 2024
@damianpumar damianpumar self-requested a review April 1, 2024 15:24
@damianpumar
Copy link
Contributor

Hello @paulbauriegel 👋
Thanks for this contribution.

I'll take a look!

@damianpumar
Copy link
Contributor

Hello again @paulbauriegel
I tested your changes and it works! But we have some UI issues because some words are a bit long.
Here I created a PR to switch language based on the browser language. #4690

Tomorrow we'll improve some UI bugs and we'll merge it.

Many thanks for this amazing contribution and keep improving Argilla together!!

@damianpumar
Copy link
Contributor

Hello @paulbauriegel this morning we pushed one change into develop, now you can try your translation.
Before approve your PR could you please update the CHANGELOG.md

Thanks!

@paulbauriegel
Copy link
Contributor Author

I tested it again, but I think it might make sense to add a couple more values to the translation js files
image

@paulbauriegel
Copy link
Contributor Author

@damianpumar I added most of the changes that are relevant to have the feedback task and major UI elements multi-lingual. I would add the changes for other tasks like Text2Text etc in a second MR to make this one not too big. Changelog is updated if there is anything else Todo let me know.

@damianpumar
Copy link
Contributor

Hi @paulbauriegel you can merge it when you want!

Many thanks for your amazing work!

@paulbauriegel
Copy link
Contributor Author

@damianpumar I don't have the rights to merge it myself, but please go ahead and merge it :-)

@damianpumar damianpumar merged commit 0783e55 into argilla-io:develop Apr 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Indicates that an issue or pull request is related to the User Interface (UI) language: javascript Pull requests or issues that update Javascript code severity: minor Indicates that the issue isn't urgent or blocking size:L This PR changes 100-499 lines, ignoring generated files. team: frontend Indicates that the issue or pull request is owned by the frontend team type: improvement Indicates updates or improvements on existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants