Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ feat/new suggestions UI #4682

Merged
merged 7 commits into from
Apr 16, 2024
Merged

✨ feat/new suggestions UI #4682

merged 7 commits into from
Apr 16, 2024

Conversation

damianpumar
Copy link
Contributor

  • New design for suggestions

Old design

Screenshot 2024-03-25 at 19 52 50

New design

Screenshot 2024-03-25 at 19 52 43

@damianpumar damianpumar self-assigned this Mar 25, 2024
Copy link

The URL of the deployed environment for this PR is https://argilla-quickstart-pr-4682-ki24f765kq-no.a.run.app

@Amelie-V
Copy link
Member

Amelie-V commented Mar 26, 2024

Corrections inside the issue scope

  • Lack of legibility of the icon: Or we redesign it or we increase a bit components size (the main issue is with the rating Quest.)
  • Into single and multi labels questions: add a bit of space between text label and icon
  • Remove the broken icon image into the tooltip

Improvement related but outside of the issue scope (but with the same priority)

  • Remove the suggestion icon at question level
  • Provide the score + the agent info into the tooltip at label level
  • Don't repeat the suggestion value into the tooltip at label level (screenshot)

@Amelie-V
Copy link
Member

Screenshot 2024-03-26 at 12 37 25

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 26, 2024
@damianpumar damianpumar merged commit 3c26364 into develop Apr 16, 2024
13 checks passed
@damianpumar damianpumar deleted the feat/new-suggestions-ui branch April 16, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Suggestions - UI] Improve and align the way to show suggestions in UI for all Questions Type
2 participants