-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): copy datasets feature #263
Conversation
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
+ Coverage 90.37% 90.62% +0.24%
==========================================
Files 58 58
Lines 1819 1867 +48
==========================================
+ Hits 1644 1692 +48
Misses 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM! Just a few minor inline comments.
Co-authored-by: David Fidalgo <david@recogn.ai>
Co-authored-by: David Fidalgo <david@recogn.ai>
Co-authored-by: David Fidalgo <david@recogn.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfecto
This PR addresses discussions from this issue
Dataset copy internally uses elasticsearch index clone, that requires source index in read-only mode. Logging records into a dataset that is being copied could lost data.
The clone index feature is include since version 7.4.x, so rubrix instances using older elasticsearch versions won't support this new feature