Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): copy datasets feature #263

Merged
merged 15 commits into from
Aug 18, 2021
Merged

Conversation

frascuchon
Copy link
Member

@frascuchon frascuchon commented Aug 5, 2021

This PR addresses discussions from this issue

Dataset copy internally uses elasticsearch index clone, that requires source index in read-only mode. Logging records into a dataset that is being copied could lost data.

The clone index feature is include since version 7.4.x, so rubrix instances using older elasticsearch versions won't support this new feature

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #263 (22f4276) into master (525d44a) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #263      +/-   ##
==========================================
+ Coverage   90.37%   90.62%   +0.24%     
==========================================
  Files          58       58              
  Lines        1819     1867      +48     
==========================================
+ Hits         1644     1692      +48     
  Misses        175      175              
Flag Coverage Δ
pytest 90.62% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/__init__.py 94.44% <100.00%> (+0.32%) ⬆️
src/rubrix/client/__init__.py 83.90% <100.00%> (+0.47%) ⬆️
src/rubrix/server/commons/errors.py 87.50% <100.00%> (+1.78%) ⬆️
src/rubrix/server/commons/es_wrapper.py 98.90% <100.00%> (+0.21%) ⬆️
src/rubrix/server/datasets/api.py 85.71% <100.00%> (+1.71%) ⬆️
src/rubrix/server/datasets/dao.py 92.30% <100.00%> (+0.52%) ⬆️
src/rubrix/server/datasets/model.py 100.00% <100.00%> (ø)
src/rubrix/server/datasets/service.py 89.23% <100.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 525d44a...22f4276. Read the comment docs.

@frascuchon frascuchon added the type: breaking changes This issue or PR may include breaking changes in the code label Aug 16, 2021
Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM! Just a few minor inline comments.

src/rubrix/__init__.py Outdated Show resolved Hide resolved
src/rubrix/__init__.py Outdated Show resolved Hide resolved
src/rubrix/server/datasets/api.py Outdated Show resolved Hide resolved
src/rubrix/server/datasets/api.py Outdated Show resolved Hide resolved
src/rubrix/__init__.py Outdated Show resolved Hide resolved
src/rubrix/__init__.py Outdated Show resolved Hide resolved
tests/client/test_client.py Show resolved Hide resolved
Copy link
Contributor

@dcfidalgo dcfidalgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto

@frascuchon frascuchon merged commit 654cc23 into master Aug 18, 2021
@frascuchon frascuchon deleted the feature/copy_datasets_feature branch August 18, 2021 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: breaking changes This issue or PR may include breaking changes in the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants