Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup and install with AWS #237

Merged
merged 4 commits into from
Aug 5, 2021
Merged

setup and install with AWS #237

merged 4 commits into from
Aug 5, 2021

Conversation

frascuchon
Copy link
Member

This is a WIP for setup installation in AWS using docker-machine.

@dvsrepo
Copy link
Member

dvsrepo commented Jul 30, 2021

@ignacioct can you

(1) review this for spelling and structure
(2) convert to rst (and make sure the conversion does not introduce errors in links, headings, etc.)
(3) add this as a new section to the get started: "Setup and installation in cloud providers"

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@e6a1199). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #237   +/-   ##
=========================================
  Coverage          ?   64.01%           
=========================================
  Files             ?      165           
  Lines             ?     6388           
  Branches          ?        0           
=========================================
  Hits              ?     4089           
  Misses            ?     2299           
  Partials          ?        0           
Flag Coverage Δ
pytest 64.01% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a1199...bfdbc15. Read the comment docs.

@ignacioct
Copy link
Contributor

It's done. I've used https://github.com/miyakogi/m2r, which works very well in my opinion.

I've corrected some typos, but the original structure of the .md has been preserved. Take a look at the result, and tell me if it need any change or it can be merged.

@dvsrepo
Copy link
Member

dvsrepo commented Aug 4, 2021

💯 @ignacioct

@frascuchon frascuchon marked this pull request as ready for review August 5, 2021 08:19
@frascuchon frascuchon merged commit a400054 into master Aug 5, 2021
@frascuchon frascuchon deleted the docs/setup_and_install_aws branch August 5, 2021 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants