-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove support for missing
response status
#4533
Comments
🤖 Hey there, @frascuchon! Good to see you around the Argilla repo again. How's it going? Based on the information provided in the class ResponseStatusFilter(str, Enum):
draft = "draft"
missing = "missing" # Deprecated, use pending instead
pending = "pending"
submitted = "submitted"
discarded = "discarded" Source: src/argilla/server/enums.py Additionally, there is functionality in the Argilla codebase that relies on the Here is the relevant code: @router.post(
"/datasets/{dataset_id}/records/search",
status_code=status.HTTP_200_OK,
response_model=SearchRecordsResult,
response_model_exclude_unset=True,
)
async def search_dataset_records(
*,
db: AsyncSession = Depends(get_async_db),
search_engine: SearchEngine = Depends(get_search_engine),
dataset_id: UUID,
body: SearchRecordsQuery,
metadata: MetadataQueryParams = Depends(),
sort_by_query_param: SortByQueryParamParsed,
include: Optional[RecordIncludeParam] = Depends(parse_record_include_param),
response_statuses: List[ResponseStatusFilter] = Query([], alias="response_status"),
offset: int = Query(0, ge=0),
limit: int = Query(default=LIST_DATASET_RECORDS_LIMIT_DEFAULT, ge=1, le=LIST_DATASET_RECORDS_LIMIT_LE),
current_user: User = Security(auth.get_current_user),
):
...
search_responses = await _get_search_responses(
db=db,
search_engine=search_engine,
dataset=dataset,
search_records_query=body,
limit=limit,
offset=offset,
parsed_metadata=metadata.metadata_parsed,
response_statuses=response_statuses,
sort_by_query_param=sort_by_query_param,
)
... Source: src/argilla/server/apis/v1/handlers/datasets/records.py To remove the SourcesThis response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research. Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant. If you want to continue the conversation, start your reply with @dosu-bot. |
<!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR removes the `missing` value for response status filters in the python SDK. Closes [#4533](#4533) **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] New feature (non-breaking change which adds functionality) - [X] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Test A - [ ] Test B **Checklist** - [ ] I added relevant documentation - [ ] I followed the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [X] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: nataliaElv <natalia@argilla.io> Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
<!-- Thanks for your contribution! As part of our Community Growers initiative 🌱, we're donating Justdiggit bunds in your name to reforest sub-Saharan Africa. To claim your Community Growers certificate, please contact David Berenstein in our Slack community or fill in this form https://tally.so/r/n9XrxK once your PR has been merged. --> # Description This PR removes the `missing` value for response status filters in the python SDK. Closes [#4533](#4533) **Type of change** (Please delete options that are not relevant. Remember to title the PR according to the type of change) - [ ] New feature (non-breaking change which adds functionality) - [X] Refactor (change restructuring the codebase without changing functionality) - [ ] Improvement (change adding some improvement to an existing functionality) **How Has This Been Tested** (Please describe the tests that you ran to verify your changes. And ideally, reference `tests`) - [ ] Test A - [ ] Test B **Checklist** - [ ] I added relevant documentation - [ ] I followed the style guidelines of this project - [ ] I did a self-review of my code - [ ] I made corresponding changes to the documentation - [ ] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I filled out [the contributor form](https://tally.so/r/n9XrxK) (see text above) - [X] I have added relevant notes to the `CHANGELOG.md` file (See https://keepachangelog.com/) --------- Co-authored-by: nataliaElv <natalia@argilla.io> Co-authored-by: David Berenstein <david.m.berenstein@gmail.com>
See the
CHANGELOG.md
entry line: https://github.com/argilla-io/argilla/blob/develop/CHANGELOG.md?plain=1#L59The text was updated successfully, but these errors were encountered: