Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't unselect all internal device sensors, even if an external device is connected #19

Open
manuelzomer opened this issue Sep 22, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@manuelzomer
Copy link
Contributor

Describe the bug
In the sensor settings it is not possible to unselect all internal sensors (one sensor always stays) even if an external device is connected. In comparison, the Android version lets you unselect all internal sensors as long as any external sensor of a connected device is selected.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the sensor settings
  2. Add an external device
  3. Select a sensor of the external device
  4. Try to unselect all internal sensors

Expected behavior
As long as an external device is connected (and a sensor of this connected device is selected), it should be possible to unselect all internal sensors.

@VKin-Arduino VKin-Arduino added the enhancement New feature or request label Sep 23, 2020
@emiliopavia
Copy link
Contributor

@manuelzomer @VKin-Arduino we inherited this behavior from the original codebase. The given is that we cannot have the sensors tab in the experiment empty. If we want to change the current behavior there's one edge case to consider:

• the user selects an external sensor;
• the user deselects all the internal sensors;
• the user unpairs the BLE device.

At this point there's no selected sensor in settings. What should happen then?

@manuelzomer
Copy link
Contributor Author

@emiliopavia On Android the behaviour for this edge case is, that as soon as the user unpairs the BLE device by clicking "Forget this device", the first internal sensor of the list get's selected automatically again. For consistency reasons it would be ideal to have that same behaviour for iOS as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants