Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove packages pinning #5132

Closed
glensc opened this issue Mar 27, 2023 · 3 comments · Fixed by #5202
Closed

Remove packages pinning #5132

glensc opened this issue Mar 27, 2023 · 3 comments · Fixed by #5202

Comments

@glensc
Copy link

glensc commented Mar 27, 2023

Is your feature request related to a problem? Please describe.

your renovatebot integration pins dependencies which is also affecting downstream packages.
it's ok to pin your devDependencies, but pinning on dependencies has effect on downstream packages too, resulting duplicate instances in node_modules.

$ find node_modules -name value-or-promise
node_modules/value-or-promise
node_modules/@graphql-tools/mock/node_modules/value-or-promise
node_modules/@graphql-tools/schema/node_modules/value-or-promise

Describe the solution you'd like

Remove the version pinning and update your lock file only in your repo.

so currently:

  • dependencies: value-or-promise "1.0.12"

future:

  • value-or-promise "^1.0.0" (affects downstream packages)
  • lockfile: value-or-promise "1.0.12" (does not affect downstream packages)

Describe alternatives you've considered

Additional context

@ardatan
Copy link
Owner

ardatan commented Apr 23, 2023

Would you create a PR for this change?

@glensc
Copy link
Author

glensc commented Apr 23, 2023

is the renovatebot also reconfigured not to pin back things? or it does that automatically if ranges are used?

@ardatan
Copy link
Owner

ardatan commented Apr 23, 2023

It respects ranges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants