Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Executors break field aliasing on stitched schemas #5049

Closed
4 tasks
v-morlock opened this issue Feb 13, 2023 · 2 comments
Closed
4 tasks

Executors break field aliasing on stitched schemas #5049

v-morlock opened this issue Feb 13, 2023 · 2 comments

Comments

@v-morlock
Copy link

Issue workflow progress

Progress of the issue based on the Contributor Workflow

  • 1. The issue provides a reproduction available on Github, Stackblitz or CodeSandbox

    Make sure to fork this template and run yarn generate in the terminal.

    Please make sure the GraphQL Tools package versions under package.json matches yours.

  • 2. A failing test has been provided
  • 3. A local solution has been provided
  • 4. A pull request is pending review

Describe the bug

When using an executor combined with delegateToSchema and stitchSchemas, aliasing fields returns null instead of the aliased value

To Reproduce
Steps to reproduce the behavior:

Run npm start here: https://stackblitz.com/edit/node-qhocq7?file=index.ts

Expected behavior

Both versions should behave the same

Environment:

  • OS: macos
  • "@graphql-tools/delegate": "^9.0.26",
    "@graphql-tools/mock": "^8.7.18",
    "@graphql-tools/schema": "^9.0.16",
    "@graphql-tools/stitch": "^8.7.40",
  • NodeJS: 16
@cesarvarela
Copy link

We are having the same issue, Does anyone have a solution?

@ardatan
Copy link
Owner

ardatan commented Jun 11, 2024

I don't think this is a bug. In your executor, you don't respect the incoming execution request in your fake response.
I've added console.log there.

@ardatan ardatan closed this as completed Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants