Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide opt-in to enable dependency tracking #156

Closed
tomkerkhove opened this issue Apr 14, 2021 · 2 comments · Fixed by #159
Closed

Provide opt-in to enable dependency tracking #156

tomkerkhove opened this issue Apr 14, 2021 · 2 comments · Fixed by #159
Assignees
@stijnmoreels

Comments

@tomkerkhove
Copy link
Contributor

What feature would you like to have?
Provide opt-in to enable dependency tracking to measure performance during publishing of events.

Relates to tomkerkhove/k8s-event-grid-bridge#182
@stijnmoreels
Copy link
Member

We need a ILogger instance for that. What would be the best way to provide such an logger instance to the Azure Event Grid publisher? This publisher instance is created via a builder.

@tomkerkhove
Copy link
Contributor Author

I would provide an overload where you can pass it. If non is passed, use NullLogger.

@stijnmoreels stijnmoreels mentioned this issue May 14, 2021
Merged
@stijnmoreels stijnmoreels self-assigned this May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stijnmoreels stijnmoreels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add Event Grid telemetry dependency tracking stijnmoreels/arcus.eventgrid
2 participants
@tomkerkhove @stijnmoreels