Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract permissions base from default deny and allow #11154

Open
chiatt opened this issue Jul 8, 2024 · 0 comments
Open

Abstract permissions base from default deny and allow #11154

chiatt opened this issue Jul 8, 2024 · 0 comments

Comments

@chiatt
Copy link
Member

chiatt commented Jul 8, 2024

In version 7.6, there are now two permissions frameworks in core arches, 'standard' and 'default_deny'. The problem with the name 'standard' is that it does not clearly indicate that it is 'default allow'. In v8 we may want to change the permissions framework that arches ships with to default deny, so we wouldn't want default allow to be called 'standard'. Also, it would be clearer to future users and developers if the name were more explicit.

As @chrabyrd proposes here, we could do this by creating a 'PermissionsBase' class from which 'DefaultDeny' and 'DefaultAllow' would inherit.

Additionally, I'd suggest we remove the prefix 'Arches' from the names of both as it's really not necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant