Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oasis reconnect #137

Merged
merged 8 commits into from
Nov 5, 2020
Merged

Oasis reconnect #137

merged 8 commits into from
Nov 5, 2020

Conversation

rajivsam
Copy link
Contributor

@rajivsam rajivsam commented Nov 2, 2020

  1. Added the reconnect feature. This is similar to what is done oasis.py for the tutorial server.
  2. Updated pytorch container test cases with tests for API changes. The driver was using an old version of the arangopipe API. Corrected and verified tests.
  3. Verified tensorflow test cases.
  4. Added the connection feature with the context manager.
  5. Added the test case for the connection feature to the CI test suite. Running the CI test suite validates backward compatibility.
  6. Added an example notebook for the connection feature using the new context manager.
  7. Created a new version of arangopipe including the new connection feature, updated PyPI with version.

@rajivsam rajivsam requested a review from joerg84 November 2, 2020 07:38
Copy link
Contributor

@joerg84 joerg84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajivsam do we need to update the readme for this?

@rajivsam rajivsam merged commit df16d89 into master Nov 5, 2020
@rajivsam rajivsam deleted the oasis_reconnect branch November 5, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants