Repo cleanup #108
Merged
Repo cleanup #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 7, 2020 16:10
joerg84
reviewed
Apr 23, 2020
| self.ap = None | ||
| self.admin = None | ||
| return | ||
|
|
||
|
|
||
| if __name__ == '__main__': | ||
| unittest.main() |
There was a problem hiding this comment.
Cannot comment on bin file but do we want to checkin arangopipe/tests/pytorch/.data/ag_news_csv.tar.gz ?
There was a problem hiding this comment.
Maybe we can just wget all the data bin files? Git is not great for large files
joerg84
approved these changes
Apr 23, 2020
|
Still lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Updated the documentation for the build procedure for torch. All entries for test_datagen_config.yaml have been explained
(2) Verified that the instance works when the test_datagen_config.yaml points either to container provided db or oasis. This is the database used by the UI - the UI uses test data.
(3) Pushing the docker image now to docker hub.