Issue#93 unique identifiers #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 28, 2020 13:11
joerg84
reviewed
Mar 2, 2020
| @@ -216,6 +240,18 @@ def register_dataset(self, ds_info, user_id="authorized_user"): | |||
| def register_featureset(self, fs_info, dataset_id, \ | |||
| user_id = "authorized_user"): | |||
| """ Register a featureset. ManagedServiceConnParamThe operation requires specifying a user id. If the user id is permitted to register a featureset, then the registration proceeds, otherwise an unauthorized operation is indicated. """ | |||
| fs_name = fs_info["name"] | |||
There was a problem hiding this comment.
Can we move that into general function checking a collection?
I am just thinking about adding new entity types
There was a problem hiding this comment.
@joerg84 . So I will refactor to a single template for all entity types.
joerg84
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of registeration of datasets, models and featureset, the existence of asset name will first be checked. If it exists, a message asking the user to try a different name will be issued. If it does not exist, registeration proceeds.
Three test cases to check this for datasets, models and featuresets are added.
The log level of the lookup api has been changed to INFO, so you will not see the "heartbeat" message anymore.
arangopipe 0.0.6.9.0 pushed to PyPi
Examples in the example folder have been updated to use the new version.