Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging diff on approval failure #27

Open
albinrydberg opened this issue Jul 12, 2021 · 1 comment
Open

Logging diff on approval failure #27

albinrydberg opened this issue Jul 12, 2021 · 1 comment

Comments

@albinrydberg
Copy link

Hi.

I would like to suggest logging the difference of approved and received to stdout in case of approval failure. This would make approvals much easier to work with, especially when running tests on a build server where you can't install external reporters.
@christoffer-gamrath christoffer-gamrath mentioned this issue Sep 30, 2021
Merged
@josephwoodward
Copy link
Contributor

Is this issue still relevant in light of #29, or can it be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@josephwoodward @albinrydberg