Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Check " is escaped if present #26

Closed
Nooba opened this issue Mar 20, 2020 · 1 comment · Fixed by #30
Closed

[iOS] Check " is escaped if present #26

Nooba opened this issue Mar 20, 2020 · 1 comment · Fixed by #30

Comments

@Nooba
Copy link
Contributor

Nooba commented Mar 20, 2020

As the script expect the text to be for iOS, it fails to compile if we had non-escaped quotes in the text, as this makes the final Localizable.strings file invalid.
-> Add a check for this case to warn / error the user if the character is unescaped?
@felginep
Copy link
Contributor

Duplicate #5 ?

@felginep felginep mentioned this issue Apr 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/bugfix felginep/ad_localize
2 participants
@Nooba @felginep