chore: simplify Script/build-webdriveragent.js #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KazuCocoa
commented
Dec 28, 2022
|
|
||
| async function buildWebDriverAgent (xcodeVersion) { | ||
| LOG.info(`Cleaning ${DERIVED_DATA_PATH} if exists`); | ||
| try { | ||
| await exec('xcodebuild', ['clean', '-derivedDataPath', DERIVED_DATA_PATH, '-scheme', 'WebDriverAgentRunner'], { |
There was a problem hiding this comment.
I'll extend this to tvOS later as another pr
github-actions bot
pushed a commit
that referenced
this pull request
Dec 30, 2022
## [4.10.18](v4.10.17...v4.10.18) (2022-12-30) ### Miscellaneous Chores * simplify Script/build-webdriveragent.js ([#647](#647)) ([81dab6c](81dab6c))
|
🎉 This PR is included in version 4.10.18 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of appium/appium#17963
npm run bundlecommand will generateWebDriverAgentRunner-Runner-Sim-<build xcode version>.zipwhich includesWebDriverAgentRunner-Runner.app. I wonder if the simulator build also can be in https://github.com/appium/WebDriverAgent/releases We need to check if we need Xcode variations, the build is only for Intel (in the simulator build) etc.Anyway, this PR simplify current
Scripts/build-webdriveragent.jsto have only building WDA with current Xcode version to run it on CI