Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift] Muti-line string literals are not handled #1450

Closed
designatednerd opened this issue Jul 30, 2019 · 1 comment
Closed

[Swift] Muti-line string literals are not handled #1450

designatednerd opened this issue Jul 30, 2019 · 1 comment

Comments

@designatednerd
Copy link
Contributor

Intended outcome:

Multi-line string literals are part of the graphQL spec and should be handled by the Swift codegen.

Actual outcome:

They are not at present. See this discussion and this discussion for more details.

How to reproduce the issue:

Thanks to @lilyball for the example:

mutation {
  sendEmail(message: """
    Hello,
      World!

    Yours,
      GraphQL.
  """)
}

is equivalent to

mutation {
  sendEmail(message: "Hello,\n  World!\n\nYours,\n  GraphQL.")
}

With changes in #1441, this will turn into:

mutation {
  sendEmail(message: "Hello, World! Yours, GraphQL.")
}

Versions

2.16 and below (iOS 0.13.0 and below)

@designatednerd
Copy link
Contributor Author

This is fixed in v2.17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant