Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File upload v0.13 - Missing documentation #681

Closed
Drusy opened this issue Jul 30, 2019 · 5 comments
Closed

File upload v0.13 - Missing documentation #681

Drusy opened this issue Jul 30, 2019 · 5 comments
Assignees
Labels
docs Focuses on documentation changes
Milestone

Comments

@Drusy
Copy link

Drusy commented Jul 30, 2019

Could you provide a concret example how to use file upload for Apollo v0.13 ?
An official documentation is required for such a "complex" feature.

For example:

  • How the .graphql file should look ?
  • Where GraphQLFile instances should be passed ?

In addition, why the upload function of HTTPNetworkTransport is not part of the NetworkTransport protocol ? This would be nice for people using a custom transport layer, such as Alamofire for example.

@designatednerd
Copy link
Contributor

@Drusy It's not on the protocol mostly because if it were, it'd need to be implemented in the Web Socket transport, where it doesn't really make a lot of sense. You should still be able to add it to your custom transport though!

Thanks for filing, will try to get a better example of this together soon.

@designatednerd designatednerd self-assigned this Jul 30, 2019
@designatednerd designatednerd added the docs Focuses on documentation changes label Jul 30, 2019
@designatednerd
Copy link
Contributor

This is now up with #707 - I also made some changes to simplify the upload system while trying to document it, so thank you for encouraging me to do that!

@designatednerd designatednerd added this to the 0.15.0 milestone Aug 12, 2019
@designatednerd
Copy link
Contributor

Significant changes to this along with way better documentation of this functionality have shipped with 0.15.0.

@Cleversou1983
Copy link

@designatednerd Ellen, finally got it working! I really appreciate your help and support! Thanks so much!!!!!!!!!

@designatednerd
Copy link
Contributor

Yay! Glad it's working now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Focuses on documentation changes
Projects
None yet
Development

No branches or pull requests

3 participants